Don't create copies of indirectly returned values #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance and more importantly, fixes a memory leak caused by the original value not being destroyed. Signed-off-by: Dimitar Dobrev <[email protected]>
ddobrev
force-pushed
the
no-copies-indirect-returned-values
branch
from
a417467
to
dde6d74
Compare
ddobrev
force-pushed
the
master
branch
2 times, most recently
from
c8e9f62
to
be54a8b
Compare
ddobrev
force-pushed
the
master
branch
6 times, most recently
from
1610aa5
to
64b1efd
Compare
ddobrev
force-pushed
the
master
branch
2 times, most recently
from
c930b78
to
c38556a
Compare
ddobrev
force-pushed
the
main
branch
7 times, most recently
from
4c1e9b8
to
2fdd082
Compare
ddobrev
force-pushed
the
main
branch
3 times, most recently
from
bcf41e4
to
851ec5e
Compare
ddobrev
force-pushed
the
main
branch
2 times, most recently
from
8f64166
to
12f456e
Compare
ddobrev
force-pushed
the
main
branch
3 times, most recently
from
97610ec
to
a2aeaed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance and more importantly, fixes a memory leak caused by the original value not being destroyed.