Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-42128) Release notes week ending 8/09 #3360

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

krollins-mdb
Copy link
Collaborator

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-42128

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit 3c8d0a7
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/66b65cdb66131500086197a0
😎 Deploy Preview https://deploy-preview-3360--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krollins-mdb krollins-mdb marked this pull request as ready for review August 9, 2024 16:27
Copy link
Collaborator

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change suggested.

@@ -13,7 +40,7 @@
## Other

- Fix the jest node test (for v12) CI, so it fails when jest tests fail.
- Re-add path to Node v12 tests. Update RN tests to use same logic as Node. Clean up legacy node tests. Use ``checkout@4`` to remove warnings.
- Re-add path to Node v12 tests. Update RN tests to use same logic as Node. Clean up legacy node tests. Use `checkout@4` to remove warnings.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad on this one. We should change "tests" to "CI checks"

Copy link
Collaborator

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krollins-mdb krollins-mdb merged commit 47463f7 into mongodb:master Aug 9, 2024
6 checks passed
@krollins-mdb krollins-mdb deleted the DOCSP-42128 branch August 9, 2024 18:21
@docs-builder-bot
Copy link

docs-builder-bot commented Aug 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants