Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-41778 query size limit #3355

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

osharaf-mdb
Copy link
Contributor

@osharaf-mdb osharaf-mdb commented Aug 2, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-41778

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • programming_language
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-realm work, if any

Release Notes

  • C++ SDK

    • Sync Data/Manage Sync Subscriptions: Add a warning about the query size limit when using Device Sync.
  • Throughout the SDK Docs: Update the "Flexible Sync RQL Requirements and Limitations" section to include the query size limit when using Device Sync.

Review Guidelines

REVIEWING.md

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for device-sdk failed. Why did it fail? →

Name Link
🔨 Latest commit 8730166
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/66b2933e8456940008403434

source/sdk/cpp/sync.txt Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 2, 2024

Readability for Commit Hash: cb7ee5a

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/cpp/sync/sync-subscriptions: Grade Level: 7.1, Reading Ease: 66.94

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on adding this to the right page for each SDK! But I think we need to refine where we put it on the pages, and also maybe verify some additional details with engineering so we can communicate the limit effectively in the SDK client context.

source/includes/warning-device-sync-query-size-limit.rst Outdated Show resolved Hide resolved
source/sdk/cpp/sync/sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/dotnet/sync/flexible-sync.txt Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/java/sync/flexible-sync.txt Outdated Show resolved Hide resolved
@@ -178,6 +178,8 @@ This creates an unnamed subscription and adds it to the
:ref:`manually add the subscription <kotlin-sync-add-subscription>` to the
subscription set.

.. include:: /includes/warning-device-sync-query-size-limit.rst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here as in the Flutter page - the "Subscribe to Queries" and "Manually Manage Subscriptions" sections represent two different APIs, so we would either need to include this warning in both places or move it to the "Flexible Sync RQL Requirements and Limitations" section.

Same thing applies to the remaining pages here - Node, React Native, and Swift.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying that detail with engineering! I think we could do a little more tweaking of the wording to remove some unnecessary wordiness and be clearer about the distinction of an individual query size vs. the size of the subscription set.

Comment on lines 112 to 113
The **size limit** for a subscription to a query from your client application is **256 kB**
when using Device Sync. Exceeding this limit results in a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still reads a little confusing to me. If I have correctly understood that the size limit is per query in the subscription set, not the total subscription set, we might want to reword a little just for clarity:

We don't need to say "when using Device Sync" because we're on the subscription query page where it's understood (hopefully!) that we're talking about Sync subscriptions. And we don't need to say "from your client application" because we're in the SDK client docs.

We should also update the wording on the C++ page once we're happy with this one.

Suggested change
The **size limit** for a subscription to a query from your client application is **256 kB**
when using Device Sync. Exceeding this limit results in a
The **size limit** for any given query in your subscription set is
**256 kB**. Exceeding this limit results in a

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@osharaf-mdb osharaf-mdb merged commit 3c909ae into mongodb:master Aug 6, 2024
7 checks passed
@osharaf-mdb osharaf-mdb deleted the DOCSP-41778-query-size-limit branch August 6, 2024 21:20
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants