Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-39500): Consolidate Install page #3326

Merged
merged 22 commits into from
Jul 31, 2024

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Jul 18, 2024

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39500

Notes for Reviewer
Only five of the pages listed here should be considered to be in a "complete" state as of this PR:

  • Install
  • Apple Privacy Manifest
  • Build for tvOS
  • Install Atlas Device SDK for Flutter
  • Upgrade to Flutter SDK v2.0.0

I moved content off of existing install pages onto a bunch of other pages, but those pages will get more updates in the future to make them coherent pages. For now, you only need to confirm that the content got moved successfully and everything is still working.

Also, noting here that per conversations with the product and engineering teams, we are intentionally omitting the Java SDK (Java and Java-Kotlin) from the Install page.

Staged Page

Page Source

Add links to every SDK's pages where you got the SDK-specific information:

PR Author Checklist

Before requesting a review for your PR, please check these items:

  • Open the PR against the feature-consolidated-sdk-docs branch instead of master
  • Tag the consolidated page for:
    • genre
    • meta.keywords
    • meta.description

Naming

Links and Refs

  • Create new consolidated SDK ref targets starting with "_sdks-" for relevant sections
  • Remove or update any SDK-specific refs to use the new consolidated SDK ref targets
  • Update any Kotlin API links to use the new Kotlin SDK roles

Content

  • Shared code boxes have snippets or placeholders for all 9 languages
  • API description sections have API details or a generic placeholder for all 9 languages
  • Check related pages for relevant content to include
  • Create a ticket for missing examples in each relevant SDK: Consolidation Gaps epic

Reviewer Checklist

As a reviewer, please check these items:

  • Shared code example boxes contain language-specific snippets or placeholders for every language
  • API reference details contain working API reference links or generic content
  • Realm naming/language has been updated
  • All relevant content from individual SDK pages is present on the consolidated page

@dacharyc dacharyc added the merge to feature branch Unreleased feature - do not merge to Master label Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

Readability for Commit Hash: 889f315

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/install: Grade Level: 7.9, Reading Ease: 59.6

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@dacharyc dacharyc marked this pull request as ready for review July 19, 2024 15:55
Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have some relatively minor suggestions and comments.

Nice work, @dacharyc!

Comment on lines 15 to 16
To include these manifests in a build target that uses ``Realm``, you must
build ``Realm`` as a dynamic framework. For details, refer to the Swift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking: do these instances of "Realm" refer to the realm package? If so, should we make that a bit clearer to help with the distinction between the package being called "realm" but the product being called "Atlas Device SDK"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes up again in the "Supported Target Environments" section with Xcode compatibility info.

.. step:: Update the CocoaPods repositories

On the command line, run ``pod repo update`` to ensure
CocoaPods can access the latest available Realm versions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "Realm" instance feels like it should be updated, but I'm not certain of the context.


.. tip:: Atlas Device SDK and Realm

The SDK uses Realm Core database for device data persistence. When you
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to avoid making it seem like Realm Core persists data about the device itself. Would apply to the other note too.

Suggested change
The SDK uses Realm Core database for device data persistence. When you
The SDK uses Realm Core database for on-device data persistence. When you

@@ -0,0 +1 @@
- :ref:`sdks-build-for-android`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do people use the C++ SDK for Android projects? I thought it mostly IoT/embedded type stuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we had customers running into issues related to this which is why we had to add the info about it. I'm not sure about the context - maybe in cross-platform projects?

@@ -0,0 +1,15 @@
- :ref:`sdks-unity`

When building for Apple platforms, Apple requires any apps or third-party SDKs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the "Apple Privacy Manifest" heading here, like in the Swift and Objective-C details. Otherwise, this manifest content kinda comes out of nowhere. Looks like the heading is needed for Dart and Kotlin details too.

Comment on lines 5 to 6
The latest version of the SDK requires Dart version {+dart-minimum-version+}
or later.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't write this, but it seems more important in the new context.

Minor update to make it clear we're talking about the Atlas Device SDK and not the Dart SDK (which is what the previous link calls the Dart language environment).

Suggested change
The latest version of the SDK requires Dart version {+dart-minimum-version+}
or later.
The latest version of the Atlas Device SDK requires Dart version {+dart-minimum-version+}
or later.

Comment on lines 15 to 16
- **Mobile App Development**: For cross-platform mobile app development, use
the :ref:`sdks-build-with-react-native`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording is a bit odd when this gets expanded to the page title.

Suggested change
- **Mobile App Development**: For cross-platform mobile app development, use
the :ref:`sdks-build-with-react-native`.
- **Mobile App Development**: For cross-platform mobile app development, refer
to :ref:`sdks-build-with-react-native`.

`Kotlin Multiplatform documentation
<https://kotlinlang.org/docs/mobile/create-first-app.html>`__.

For more details on setting up your KMP environment, refer to the `official Kotlin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more details on setting up your KMP environment, refer to the `official Kotlin
For more details on setting up your KMP environment, refer to the `official

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit 889f315
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/66aa374ff816e70008f52455
😎 Deploy Preview https://deploy-preview-3326--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32 (🔴 down 3 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 75 (no change from production)
SEO: 62 (🔴 down 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dacharyc dacharyc merged commit 7f294fe into mongodb:feature-consolidated-sdk-docs Jul 31, 2024
10 checks passed
@dacharyc dacharyc deleted the DOCSP-39500 branch July 31, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge to feature branch Unreleased feature - do not merge to Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants