Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reports #50

Closed
wants to merge 3 commits into from
Closed

Update reports #50

wants to merge 3 commits into from

Conversation

scilganon
Copy link
Contributor

#46 am i on the right way to update reports to the new schema?

@scilganon
Copy link
Contributor Author

@slodki should be done such changes? is anybody already did it?

@slodki
Copy link
Contributor

slodki commented Dec 26, 2018

Please use new check_gm script from #51 - correct DB schema will be downloaded on-the-fly

@slodki
Copy link
Contributor

slodki commented Dec 26, 2018

This report is very buggy - it ignores split transactions, sums up different currencies etc. It's quite easy to update SQL to renamed table names, but it's hard to support latest MMEX features.

@scilganon
Copy link
Contributor Author

@slodki whom i can ask to format list of all features, which should be tested?

my next steps:

  • form dataset with all features
  • rewrite test to check not only valid queries, but its results with asserts

do you know any tools which could help to right such tests?

@slodki
Copy link
Contributor

slodki commented Dec 28, 2018

Please check #53 for common problems with MMEX errors. UML diagram in database README can help to create right SQL queries like in #1662

@slodki
Copy link
Contributor

slodki commented Dec 28, 2018

GRM flow: SQLite → SQL → Lua → template → JS → HTML
GRM reports can use user-selected parameters and filters to modify output.
It's hard to verity if values presented in HTML are correct using prepared sample transactions in db IMHO.

@vomikan
Copy link
Member

vomikan commented Apr 17, 2020

I've made a lot of changes with this repo.

  • Report grouping
  • Only DB v7 support
  • Readme.md for all groups

mmex v 1.4.0 stuck

@vomikan vomikan closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants