Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining: add compile time option to disable p2pool #3926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented May 20, 2022

P2Pool doesn't work with all package manager setups, so it's best to add an option to disable it during compile time.

@devhyper @BigmenPixel0 @kpcyrd

@plowsof
Copy link
Contributor

plowsof commented May 20, 2022

This would be great! i've seen / helped many users who are confused as to why their 'package manager' installed Monero GUI displays the 'p2pool failed to install message. UX ++

@BigmenPixel0
Copy link
Contributor

BigmenPixel0 commented May 21, 2022

I added p2pool to flatpak. Just haven't checked yet

@kpcyrd
Copy link

kpcyrd commented May 21, 2022

Is there something that can be done to fix the packages instead? :) I wasn't aware of any issues yet.

@selsta
Copy link
Collaborator Author

selsta commented May 21, 2022

The GUI downloads the p2pool binary in the same directory as the monero-wallet-gui binary. I can imagine that package managers don't like this, as it's not the proper way to install something and also might cause permission issues.

Putting p2pool directly during the installation process in the same folder as monero-wallet-gui might work. Then you wouldn't need to disable it during compile time. But this has to be tested, as there are also log and config files written which again might cause permission issues.

@selsta
Copy link
Collaborator Author

selsta commented May 21, 2022

Basically two options:

  1. Disable during compile time
  2. Install p2pool together with monero-wallet-gui, assuming everything was tested and works correctly

@kpcyrd
Copy link

kpcyrd commented May 22, 2022

p2pool is now available in Arch Linux: https://archlinux.org/packages/community/x86_64/p2pool/.

pacman -S p2pool installs a binary to /usr/bin/p2pool, the same directory that also contains monero-wallet-gui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants