-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default value of DELEGATE_AUTHORIZED_ROLES #346
Open
haruki-yamanashi
wants to merge
2
commits into
monasca:master
Choose a base branch
from
haruki-yamanashi:delegate-authorized-roles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change default value of DELEGATE_AUTHORIZED_ROLES #346
haruki-yamanashi
wants to merge
2
commits into
monasca:master
from
haruki-yamanashi:delegate-authorized-roles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haruki-yamanashi
force-pushed
the
delegate-authorized-roles
branch
from
November 28, 2017 09:52
be9d6d0
to
88c254b
Compare
https://github.com/openstack/monasca-agent/blob/master/docs/MonascaMetrics.md#cross-tenant-metric-submission |
Don't you also need to change it in Keystone? |
@matrixik But only in OpenStack's Keystone. The only scenario when delegate roles are used, is libvirt monitoring. |
Every time same tempest test fail:
|
Change default value of DELEGATE_AUTHORIZED_ROLES from `admin` to `monitoring-delegate` because of following two reasons. - There is inconsistency between monasca-docker default value and OpenStack monasca agent project document. - It's not secure to allow admin authorization to other users.
haruki-yamanashi
force-pushed
the
delegate-authorized-roles
branch
from
December 7, 2017 10:20
63a109c
to
16db182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default value of DELEGATE_AUTHORIZED_ROLES from
admin
tomonitoring-delegate
because of following two reasons.OpenStack monasca api project document.