Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024a.json #1098

Closed
wants to merge 1 commit into from
Closed

Update 2024a.json #1098

wants to merge 1 commit into from

Conversation

wiserweb
Copy link

Removed Phoenix, Puerto_Rico, Panama which are not located in Canada and do not function as timezones for the country's zone.

Removed Phoenix, Puerto_Rico, Panama which are not located in Canada and do not function as timezones for the country's zone.
Copy link

linux-foundation-easycla bot commented Feb 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wiserweb / name: wiserweb (d38ea5b)

@gilmoreorless
Copy link
Member

Hi, thanks for your contribution, but I'm going to close this PR for two reasons:

  1. The data files are auto-generated from the IANA tzdb releases. Any manual changes like this will be overwritten the next time a tzdb release happens. (Additionally, most installations of Moment Timezone read from a duplicate latest file that hasn't been altered in this PR.)
  2. I know it's confusing and not obvious, but the data file is correct for what it's intended to track. The short version is "it's not saying that all these zones are definitely in Canada, just that time in Canada can be represented by these zones". The longer version is Czechia and Slovakia timezone mixup #1066 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants