Expose connect options and the client socket via a _mitm property #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moll Any feedback on this, or the general idea of providing it? |
papandreou
force-pushed
the
feature/exposeClientSocketAndOptions
branch
from
c1727bd
to
eaf0459
Compare
|
This PR also gives a nice way to bypass requests. Like described in #16. |
|
@moll Is there any update on this? My specific problem is that I use |
|
Ping @moll? |
|
I think this still needs addressing. I'll reopen to come around to it eventually. And oh, Feb 17, 2020— that was almost before the apocalypse. Good times! |
|
@moll Hi there! This looks super useful, do you think this MR could be moved forward? TIA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
I ran into a scenario where it was impossible to pair up client sockets, connect options, and HTTP requests using the current API.
This (or something similar) makes it possible to avoid the guesswork and actually simplify my code a bit: https://github.com/unexpectedjs/unexpected-mitm/pull/19/files