-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sync] Update to DashMap 6 #34
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 91.90% 91.84% -0.06%
==========================================
Files 23 23
Lines 4125 4097 -28
==========================================
- Hits 3791 3763 -28
Misses 334 334 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could have bumped MSRV up to 1.65
for dashmap 6, but since 1.76
came out 6 months ago this can remove the version restriction on triomphe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It looks good to me.
Just FYI, before releasing next version of mini-moka
with this DashMap
update, I will try to remove triomphe
from the dependency and copy necessary codes from triomphe
to mini-moka
. (a relevant comment in a moka
's issue). And then I will change the MSRV to 1.65. I am hoping to do it in next weekend.
If it takes too long, I will release the next version of mini-moka
without removing triomphe
. And its MSRV will be 1.76.
This is a breaking change due to the removal of the
S
generic parameter from EntryRef, but improves performance a ton apparently.