Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merchant registry helm charts #598

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tw-sithumyo
Copy link

No description provided.

Copy link
Collaborator

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor changes.

Also, are there any services in these charts that need to be deployed as part of core Mojaloop deployment?

merchant-registry-svc/Chart.yaml Outdated Show resolved Hide resolved
merchant-registry-svc/Chart.yaml Outdated Show resolved Hide resolved
merchant-registry-svc/Chart.yaml Outdated Show resolved Hide resolved
update-charts-dep.sh Show resolved Hide resolved
@elnyry-sam-k
Copy link
Member

Thanks @oderayi and @tw-sithumyo ..

Please hold off on the merge while iterating on these changes; And until all the image versions used are greater than v1.0.0 indicating that they're release / production quality

@stmSi
Copy link

stmSi commented Feb 5, 2024

hello @oderayi , thanks for thorough review, I made changes according to your suggestions.
Yes @elnyry-sam-k , we hold off the merging for now.

@tw-sithumyo tw-sithumyo force-pushed the feat/add-merchant-registry-helms branch from a8d077a to ac3e6d0 Compare February 8, 2024 03:49
@tw-sithumyo
Copy link
Author

version has been bumped to 1.0.x.

@tw-sithumyo tw-sithumyo force-pushed the feat/add-merchant-registry-helms branch from 9a6f7ed to 809edd3 Compare February 15, 2024 02:25
spec:
automountServiceAccountToken: false
containers:
- name: merchant-db

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarCloud
@elnyry-sam-k
Copy link
Member

Thanks @tw-sithumyo; Two items left from the sonar check, please review.

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

@tw-sithumyo
Copy link
Author

Hello @elnyry-sam-k , the storaged limit related 2 issues has been resolved.

@elnyry-sam-k
Copy link
Member

Once this is ready, we'll have to change the "base" branch to "v16.0.0-rc-1" so that it can be tested with the v16 RC codebase and then shipped after passing the release criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants