-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a webpage server to read tsv data and provide search/pagination #57
Conversation
Adding Map Functionality would be great |
server/requirements.txt
Outdated
@@ -0,0 +1,173 @@ | |||
abstract_singleton==1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need all these dependencies ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Sorry, I had missed the activation of venv, which brought in these many dependencies, I have fixed it now, and pushed the updated requirements.txt file.
Thanks again for reminding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make env
[virtual_env] and update dependency
Also, I think post
method would be more suitable instead of get
for passing the information.
server/requirements.txt
Outdated
@@ -0,0 +1,173 @@ | |||
abstract_singleton==1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many dependencies listed, which could lead to conflicts during future installations.
Maintain only essential libraries, like flask
. Please ensure that unrelated dependencies such as colorama
are not included in requirements.txt.
Additionally, please recheck the file and remove unnecessary dependencies like scikit-learn
, openai
, hugging-face
, tqdm
, and more
There should not be this much dependencies. Make it <15 dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Sorry, I had missed the activation of venv, which brought in these many dependencies, I have fixed it now, and pushed the updated requirements.txt file.
Thanks again for reminding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding passing information, and post request, I believe GET request is appropriate in this case, as we are
retrieving query parameters from the request.
I believe this is trying to add a web interface and using HTML CSS JS and might be accessible to lot more developers, avoids vendor lockin and probably more flexible as well. However one also needs to consider the deployment strategy for this, is ministry willing or has required resources for maintaining such a deployment? I would like to point out that #44 has been merged introducing streamlit to codebase which serves similar purpose. It has a free tier cloud based deployment. Appreciate the effort put in by everybody and not to discourage anybody from participating but lets make sure the efforts are not divergent. |
I also believe that while Streamlit currently offers a sufficient basic webview, we might need to explore other frameworks in the future that provide more features and flexibility. |
Add a webpage server to read tsv data and provide search/pagination functionalities.
This is an initial implementation of data filtering and pagination and still has a huge room to be filled in terms of UI/UX
but if the PR gets approved, I would be happy to work on that.
Also, in case of approval, I will immediately work on adding a feature that would make it easier for users to find the pathway from one center to the next (this will be a leaflet based map for visual representation) . This will be done in TDD manner, with lots of unit tests.
I have added a readme file inside the "server" directory, which contains info to get started.
Below is a screenshot of what has been built so far.