-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Refine grids code to correct actions access and visibility (revised) #15919
Open
smg6511
wants to merge
23
commits into
modxcms:3.x
Choose a base branch
from
smg6511:3.x-grids-perms-validation-pr01
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cdcf096 - Browse repository at this point
Copy the full SHA cdcf096View commit details -
Made various updates in response to reviewers' feedback. (No functionality/feature changes were made.)
Configuration menu - View commit details
-
Copy full SHA for 98fce3f - Browse repository at this point
Copy the full SHA 98fce3fView commit details -
Remove type declarations from class properties
Previous updates were not passing unit tests due to use of php 7.4+ feature.
Configuration menu - View commit details
-
Copy full SHA for 5182282 - Browse repository at this point
Copy the full SHA 5182282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3128a17 - Browse repository at this point
Copy the full SHA 3128a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for f299d82 - Browse repository at this point
Copy the full SHA f299d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77729f5 - Browse repository at this point
Copy the full SHA 77729f5View commit details -
Keeping work in progress up to date with current dev branch
Configuration menu - View commit details
-
Copy full SHA for 33492ca - Browse repository at this point
Copy the full SHA 33492caView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc783fb - Browse repository at this point
Copy the full SHA dc783fbView commit details -
Made various updates in response to reviewers' feedback. (No functionality/feature changes were made.)
Configuration menu - View commit details
-
Copy full SHA for e548b58 - Browse repository at this point
Copy the full SHA e548b58View commit details -
Keeping work in progress up to date with current dev branch
Configuration menu - View commit details
-
Copy full SHA for 004fffa - Browse repository at this point
Copy the full SHA 004fffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08fd558 - Browse repository at this point
Copy the full SHA 08fd558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b78298 - Browse repository at this point
Copy the full SHA 3b78298View commit details -
Revert edit and remove prop names and visibility
Change back to public class props
Configuration menu - View commit details
-
Copy full SHA for 4ab6c53 - Browse repository at this point
Copy the full SHA 4ab6c53View commit details
Commits on Sep 9, 2024
-
Base js updates and default lexicon update
Various functionality-related changes to grid base js class and utilities lib
Configuration menu - View commit details
-
Copy full SHA for b02babe - Browse repository at this point
Copy the full SHA b02babeView commit details -
Various additions and optimizations, as well as code quality improvements
Configuration menu - View commit details
-
Copy full SHA for b32288a - Browse repository at this point
Copy the full SHA b32288aView commit details -
Various additions and optimizations, as well as code quality improvements
Configuration menu - View commit details
-
Copy full SHA for 239a57c - Browse repository at this point
Copy the full SHA 239a57cView commit details -
Small tweaks and carry through of methods used in other core object classes to identify protected data keys
Configuration menu - View commit details
-
Copy full SHA for ad0a372 - Browse repository at this point
Copy the full SHA ad0a372View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5df061 - Browse repository at this point
Copy the full SHA a5df061View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c50b6 - Browse repository at this point
Copy the full SHA a7c50b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cb63b8 - Browse repository at this point
Copy the full SHA 9cb63b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9651b27 - Browse repository at this point
Copy the full SHA 9651b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for a36270d - Browse repository at this point
Copy the full SHA a36270dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2c32d - Browse repository at this point
Copy the full SHA 6f2c32dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.