Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert everything to ESM #2600

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Convert everything to ESM #2600

wants to merge 26 commits into from

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Jan 5, 2024

I think we just need to pull the bandaid off and deal with issues that arise. Trying to do this piece meal feels impossible.

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: d9868b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@web/storybook-framework-web-components Major
@web/rollup-plugin-import-meta-assets Major
@web/rollup-plugin-polyfills-loader Major
@web/test-runner-visual-regression Major
@web/test-runner-junit-reporter Major
@web/test-runner-browserstack Major
@web/test-runner-coverage-v8 Major
@web/dev-server-import-maps Major
@web/test-runner-playwright Major
rollup-plugin-workbox Major
@web/test-runner-puppeteer Major
@web/test-runner-saucelabs Major
@web/test-runner-webdriver Major
@web/dev-server-storybook Major
@web/test-runner-commands Major
@web/test-runner-selenium Major
@web/dev-server-polyfill Major
@web/dev-server-esbuild Major
@web/rollup-plugin-copy Major
@web/rollup-plugin-html Major
@web/test-runner-chrome Major
@web/dev-server-legacy Major
@web/dev-server-rollup Major
@web/storybook-builder Major
@web/test-runner-mocha Major
@web/polyfills-loader Major
@web/test-runner-core Major
@web/dev-server-core Major
@web/storybook-utils Major
@web/test-runner-cli Major
@web/dev-server-hmr Major
@web/config-loader Major
@web/browser-logs Major
@web/parse5-utils Major
@web/test-runner Major
@web/dev-server Major
@web/mocks Major
@web/test-runner-module-mocking Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson marked this pull request as ready for review January 5, 2024 10:28
@Westbrook
Copy link
Member

This looks exciting! Need to dig deeper on the code but some questions:

Have you tested the prerelease distributions of these packages in an external project? next always releases these.

Would we need to also pull the bandaid in the Open WC packages to satisfy a “full” release of these type of changes?

@koddsson
Copy link
Contributor Author

koddsson commented Jan 5, 2024

Have you tested the prerelease distributions of these packages in an external project? next always releases these.

I did run it on one project I got at work but maybe I could do more installs. I was hoping other people might also check it out in their projects and report back if there are any errors.

@koddsson koddsson closed this Jan 5, 2024
@koddsson koddsson reopened this Jan 5, 2024
@koddsson
Copy link
Contributor Author

koddsson commented Jan 5, 2024

Whoops!

@koddsson koddsson mentioned this pull request Jan 31, 2024
14 tasks
@koddsson
Copy link
Contributor Author

@bashmish; this is now conflicting. Can you resolve those?

@bashmish
Copy link
Member

bashmish commented Feb 19, 2024

@bashmish; this is now conflicting. Can you resolve those?

done
I had to remove the "retrocompatibility" for import { globals } from '@storybook/preview/globals'; as it seems more difficult to support in the ESM world and not really needed given people will easily upgrade to latest storybook packages to resolve it, and I think it's needed for ESM anyway.

@bashmish
Copy link
Member

@koddsson shouldn't we also update the demos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants