-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert everything to ESM #2600
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d9868b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This looks exciting! Need to dig deeper on the code but some questions: Have you tested the prerelease distributions of these packages in an external project? Would we need to also pull the bandaid in the Open WC packages to satisfy a “full” release of these type of changes? |
I did run it on one project I got at work but maybe I could do more installs. I was hoping other people might also check it out in their projects and report back if there are any errors. |
Whoops! |
@bashmish; this is now conflicting. Can you resolve those? |
done |
@koddsson shouldn't we also update the demos? |
I think we just need to pull the bandaid off and deal with issues that arise. Trying to do this piece meal feels impossible.