Fix output format of @web/dev-server-storybook
#2407
Conversation
🦋 Changeset detectedLatest commit: 4dfc0fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
koddsson
changed the title
@web/dev-server-storybook
| @@ -1,7 +1,8 @@ | |||
| import mdx from '@mdx-js/mdx'; | |||
| import { transformAsync } from '@babel/core'; | |||
| // @ts-ignore | |||
| import { createCompiler } from '@storybook/csf-tools/mdx'; | |||
There was a problem hiding this comment.
I get this error:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/westbrookjohnson/Documents/repos/spectrum-web-components/node_modules/@storybook/csf-tools/mdx' imported from /Users/westbrookjohnson/Documents/repos/spectrum-web-components/node_modules/@web/dev-server-storybook/dist/shared/mdx/transformMdxToCsf.js
Did you mean to import @storybook/csf-tools/mdx.js?
at new NodeError (node:internal/errors:387:5)
at finalizeResolution (node:internal/modules/esm/resolve:429:11)
at moduleResolve (node:internal/modules/esm/resolve:1006:10)
at defaultResolve (node:internal/modules/esm/resolve:1214:11)
at nextResolve (node:internal/modules/esm/loader:165:28)
at ESMLoader.resolve (node:internal/modules/esm/loader:844:30)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:431:18)
at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
at link (node:internal/modules/esm/module_job:75:36) {
code: 'ERR_MODULE_NOT_FOUND'
}
Goes away if I add .js locally, but then I get a different error.
There was a problem hiding this comment.
I confirm this
the 2nd error in chain is
/path/to/project/node_modules/@web/dev-server-storybook/dist/build/rollup/createRollupConfig.js:4
import html from '@web/rollup-plugin-html';
^^^^
SyntaxError: The requested module '@web/rollup-plugin-html' does not provide an export named 'default'
at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
@koddsson did you test this change with some storybook?
There was a problem hiding this comment.
I didn't manually test this no. I was kind of relying on the tests to catch this. I find it weird that they didn't 🤔
I haven't had a lot of time to look into this but I am trying to fix this today. I've gotten to a point where I don't get any errors in a local project but I am just getting a empty page so I'm looking further.
There was a problem hiding this comment.
@koddsson are there integration tests that run a real storybook in the test environment or smth like that? if so, maybe good to improve that to detect such cases
but I thought we didn't have them, maybe some unit tests only or so, but I didn't look into that yet
for the Storybook v7 migration I think we need to improve a lot in this space
There was a problem hiding this comment.
I think I got this fixed now. It's at least working in my local project and the tests are all running green locally. Could you take a look at #2415 @Westbrook and @bashmish ?
Set
moduleResolutiontonode16so that TypeScript will output ES Modules and changed themoduleproperty so that it's not a moving target.Fixes #2405