Try chai@next
#2176
Closed
Try chai@next
#2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39ea02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This is looking good! I'm thinking I'll let this sit until Chai@5 lands. |
thepassle
reviewed
Mar 25, 2023
| @@ -14,7 +14,6 @@ | |||
| }, | |||
| "author": "modern-web", | |||
| "homepage": "https://github.com/modernweb-dev/web/tree/master/packages/test-runner-integration-tests", | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
It's unrelated to the chai changes. I was just getting warnings when running the tests:
(node:87634) [DEP0128] DeprecationWarning: Invalid 'main' field in '/src/web/integration/test-runner/package.json' of 'index.js'. Please either fix that or report it to the module author
|
This is cool dude, nice work. Changes look pretty straightforward (mostly import changes), nice. |
|
while you're killing it here, any thoughts on a |
Sure! I'll look into that 😄 |
koddsson
force-pushed
the
try-chai-next
branch
6 times, most recently
from
3fa8733
to
4c7618a
Compare
Using capital "D" `Default` is a super common pattern in Storybook creation. While we're pushing for `Regular` or similar in some of our CLI tooling, not allowing it at all is a surprising side effect for consumers of this package.
…puppeteer with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the
chai@5prerelease so we can see if there are issues that we can feed back to the chai team.