Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update CMake to allow for prebuild dependencies #129

Closed
wants to merge 3 commits into from

Conversation

mathomp4
Copy link
Contributor

@mathomp4 mathomp4 commented May 3, 2023

WORK IN PROGRESS

This is a work in progress. It works for me but I've currently broken the regular build. Nuts.


Closes #128

This PR is to allow prebuilt functional-fortran, h5fortran, and json-fortran to be used with neural-fortran.

@milancurcic
Copy link
Member

Sorry for the delay. This works well for me. I tested with system-provided builds of HDF5, both serial and OpenMPI. I also tested with a custom serial Intel build of HDF5, that builds fine too.

The only incorrect thing I found is that even when the dependencies are found the CMake reports messages like

-- h5fortran not found, fetching from GitHub

but doesn't proceed to download them. I'm confused by this because it doesn't look from e.g. cmake/functional.cmake that that should happen.

@mathomp4
Copy link
Contributor Author

@milancurcic Hmm. I'll take a look.

Though I still think I might need to consult with @scivision on h5fortran. Or, I suppose, maintain a fork of it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to build without internet access aka pre-built dependencies?
2 participants