Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to decouple current memroy into action and storage base classes. #385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Aug 6, 2024

Description

  • Decouple the current memroy class into action and storage base classes, so that
    • if users want to implement their own memory, e.g. based on a sql database, they just need to inherit the storage base class and implement the basic operations.
    • the embedding and storage operations are all implemented in storage class, so that a vdb based memory module is feasible.
  • This PR is experimental. I'm not sure if decoupling memory will incur additional cost in understanding. Any suggestions or commets are welcome.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant