Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game geoguessr #355

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

zyzhang1130
Copy link
Contributor

@zyzhang1130 zyzhang1130 commented Jul 21, 2024


name: Pull Request
about: Create a pull request

Description

created two geoguessr games based on tripadvisor api tool function

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@zyzhang1130 zyzhang1130 changed the title Game geoguessr [WIP] Game geoguessr Aug 8, 2024
@DavdGao DavdGao changed the title Game geoguessr [WIP] Game geoguessr Aug 9, 2024
@DavdGao
Copy link
Collaborator

DavdGao commented Aug 9, 2024

Modified into [WIP], and we will review this PR after merging the https://github.com/modelscope/agentscope/pull/332

update tool functions naming according to merged tripadvisor tool functions naming convention
resolve conflict
@zyzhang1130
Copy link
Contributor Author

zyzhang1130 commented Aug 30, 2024

Modified into [WIP], and we will review this PR after merging the https://github.com/modelscope/agentscope/pull/332

Removed [WIP], as https://github.com/modelscope/agentscope/pull/332 has been merged. This PR has been updated according to https://github.com/modelscope/agentscope/pull/332. The existing conflicts are due to some of the naming in https://github.com/modelscope/agentscope/pull/332 not being updated properly. It should be updated according to this PR.

@zyzhang1130 zyzhang1130 changed the title [WIP] Game geoguessr Game geoguessr Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants