Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to python 3.13 #504

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

jairhenrique
Copy link
Contributor

Describe the change
Run tests on python 3.13

PR Checklist

  • Change is covered with tests
  • CHANGELOG.md is updated if needed

Copy link
Collaborator

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take out the unrelated changes to a separate PR and keep it to the Python update. 🙏

pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. As @amureki suggested, I'd alsobe in favor of splitting the Python3.13 support from CI improvemnts/refactorings.

@amureki
Copy link
Collaborator

amureki commented Oct 10, 2024

@jairhenrique I took a liberty to amend a small patch to the test matrix. Sorry that the process there is not transparent, we'd try to improve it.
Nevertheless, many thanks for the contribution!

@amureki amureki merged commit fa833e7 into model-bakers:main Oct 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants