Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobx utils #886

Closed
wants to merge 7 commits into from
Closed

mobx utils #886

wants to merge 7 commits into from

Conversation

altynbek132
Copy link
Contributor

@altynbek132 altynbek132 commented Dec 12, 2022

added mobx utils

  • obs from Listenable
  • obs from ValueNotifier
  • Stream of obs values

at least we should have ability to convert obs values into stream since streams are very useful for async world
https://github.com/mobxjs/mobx-utils#tostream
for example we could convert computed field to stream and solve #860

added reporting manual change for observable and collections
there are some cases when you should need to report change, for example if using collections extensions (sortBy), or writing own function that converts some class similar to Listenable.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #886 (60a3085) into master (13b7e6d) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

❗ Current head 60a3085 differs from pull request most recent head 7193902. Consider uploading reports for the commit 7193902 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   98.96%   98.19%   -0.77%     
==========================================
  Files          55       55              
  Lines        1924     1939      +15     
==========================================
  Hits         1904     1904              
- Misses         20       35      +15     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 97.46% <0.00%> (-1.08%) ⬇️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/api/observable_collections/observable_list.dart 98.76% <0.00%> (-1.24%) ⬇️
...src/api/observable_collections/observable_map.dart 97.45% <0.00%> (-2.55%) ⬇️
...src/api/observable_collections/observable_set.dart 95.23% <0.00%> (-4.77%) ⬇️
mobx/lib/src/core/observable.dart 89.13% <0.00%> (-10.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b7e6d...7193902. Read the comment docs.

@ghenry
Copy link

ghenry commented Dec 19, 2022

This looks very useful too. Anyone else have review and merge perms?

@altynbek132
Copy link
Contributor Author

@pavanpodila

@amondnet
Copy link
Collaborator

I also implemented some features of mobx-utils.
https://github.com/amondnet/mobx_utils

@pavanpodila
Copy link
Member

Coverage has dropped. Can we fix that @amondnet ?

@altynbek132 altynbek132 deleted the master branch March 21, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants