Skip to content
This repository has been archived by the owner on Sep 1, 2019. It is now read-only.

Updated to work with Rclone v1.44 #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Updated to work with Rclone v1.44 #138

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2018

No description provided.

@mmozeiko
Copy link
Owner

Thanks! Let me check few things, and I'll merge it.
I'm not sure about change in utils.h for prepending space to --config. If this is fix for macOS then I think proper fix would be to add space after " config" string here:

QTextStream(tmp) << "#!/bin/sh\n" << GetRclone() << " config" << GetRcloneConf().join(" ") << "\n";

Also not sure about move -> moveto change. This probably will not work in some cases.

@ghost
Copy link
Author

ghost commented Oct 30, 2018

Thanks! Let me check few things, and I'll merge it.
I'm not sure about change in utils.h for prepending space to --config. If this is fix for macOS then I think proper fix would be to add space after " config" string here:

RcloneBrowser/src/main_window.cpp

Line 274 in 7106638

QTextStream(tmp) << "#!/bin/sh\n" << GetRclone() << " config" << GetRcloneConf().join(" ") << "\n";
Also not sure about move -> moveto change. This probably will not work in some cases.

That is for macOS, yes, but I'm not as well known in this, so if you think the proper fix would be to add space, then that's probably better.

The move -> moveto is because when I tried to move a file, let's say in Movie (2009) there was a file named Movie (2009).mkv, here's an example of the structure:
Movie (2009)
------Movie 20009.mkv
, if I tried moving it to New Location Movie (2009), it just created a new folder in the same folder as the file, so that it was now like this:
Movie (2009)
------Movie 20009.mkv (now a folder)
------------Movie 20009.mkv (the real file)

It might be something I did wrong, but it worked when move was changed to moveto.

@caspertone2003
Copy link

@mmozeiko
I enjoy a lot RcloneBrowser. Unfortunaletlly I am not able to propose PR not to compile it.
Could we have an official update release?
TIA
CTone

@caspertone2003
Copy link

@jonaknop
@MostHated

I can confirm what MostHated reported. Same issue here (use W10 x64). Tried all proposed workarounds.
Simply, it seems unable to use a custom location of config and furthermore is unable to configure the standard location either.

CTone

@caspertone2003
Copy link

@jonaknop @mmozeiko

As I noticed something strange, as I used this version while I kept the official one (1.2) (each on different directories), the second one, when opening settings, there were some values there ... of the official one.

Searching in the registry i found out two things
a) rclonebrowser is not truly portable as it stores its parameters in the registry
b) seems that there some issue with the storage in the registry, see image.

captura

@Bagmetalex
Copy link

Hello!. I am a complete zero in programming, and do not know English), could you compile your branch under windows 32 and 64 bit. I would be very grateful!

@felisucoibi
Copy link

does this work for rclone 1.41 from ubuntu 18.10 ?

@ordinarygulp
Copy link

@mmozeiko would it be possible to get this merged?

@EricTheRed1
Copy link

If you want to contact the developer, leave him a message on reddit. He is active on that site. Here is his profile. https://www.reddit.com/user/martins_m

He doesn't really hang out here anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants