Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ego entry point (Issue #138) #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jakob-r
Copy link
Member

@jakob-r jakob-r commented Jun 7, 2016

No description provided.

@berndbischl
Copy link
Member

berndbischl commented Jun 7, 2016

lets us try to specify the API here:

  1. remove init.des.points. if not, the user has to tell the system HOW to gen the init design. blows up arg signature. let the user pass the des, if he does not, do a reasonable init des. i would suggest maxminLHS with 4*d.
  2. we need more simple term conditions. budget, iters, and a bound on the y value to reach.
  3. you need to check that parset only contains numerical stuff
  4. i dont think you can let the user pass a control object. i could use that do request "weird" stuff, non-ego stuff. if you want that, the full control, use mbo.
  5. its not "visible" how the learner is constructed. at least link to some doc page for this.

@mllg ?

@jakob-r
Copy link
Member Author

jakob-r commented Jun 8, 2016

For 5 see #223

@mllg
Copy link
Member

mllg commented Dec 23, 2016

We now have makeMBOLearner which approaches this very problem from a different angle. IMHO the construction of a default learner takes away most of the pain. I guess you cannot remove the burden of some choices from the user, like the termination criteria. Unsure how we should proceed.

I guess I would rather favor to postpone this one for now.

@berndbischl
Copy link
Member

I agree that this should be postponed!

But: makeMboLearner simply constructs a reasonable default model. This PR is about something else. And more general. Lets not mix the two.

@mllg mllg removed their assignment Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants