Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates sticky toolbar #134

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Creates sticky toolbar #134

merged 2 commits into from
Aug 22, 2024

Conversation

bridgetburke
Copy link
Collaborator

@bridgetburke bridgetburke commented Aug 8, 2024

What's new

  • Creating a sticky toolbar at the top of the document
  • Style for toolbar and other minor styling
  • Small style change for "request" containers since they didn't meet contrast with the yellow bg
  • Update app/models/solr_document.rb and _show_default.html.erb (feedback from Roger)
Toolbar for findingaid

@respinos
Copy link
Contributor

respinos commented Aug 8, 2024

I think we need this after is_checkbox_requestable? in app/models/solr_document.rb:

  def is_aeon_requestable?
    repository_config.request_config_present_for_type?('aeon_web_ead')
  end

and then that last sticky block in _show_default.html.erb looks like

 <% if request_button_flag and document.is_aeon_requestable? %>
 ...
 <% end %>

@respinos
Copy link
Contributor

respinos commented Aug 8, 2024

One more time...

Add this to solr_document.rb:

  def is_possibly_requestable?
    is_aeon_requestable? or collection_has_requestable_components?
  end

and then change the last sticky block to

<% if request_button_flag and document.is_possibly_requestable? %>

@bridgetburke bridgetburke marked this pull request as ready for review August 9, 2024 15:18
@gkostin1966 gkostin1966 merged commit b2c7762 into main Aug 22, 2024
2 checks passed
@gkostin1966 gkostin1966 deleted the arc-103-request-move branch August 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants