Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GroupRecordSet call to return the sample directly. #207

Merged
merged 8 commits into from
Sep 7, 2023

Conversation

ccl-core
Copy link
Contributor

@ccl-core ccl-core commented Sep 7, 2023

Croissant now output samples in the form: {"name": "person0", "age": 0}} (instead of: {"persons": {"name": "person0", "age": 0}}, as it was before)

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ccl-core
Copy link
Contributor Author

ccl-core commented Sep 7, 2023

Hi Pierre, I'm still having a look at why the data generation pipeline seems to be broken in my codespaces. But the CI Unittests seem to be green.

@ccl-core ccl-core marked this pull request as ready for review September 7, 2023 09:48
@ccl-core ccl-core requested a review from a team as a code owner September 7, 2023 09:48
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ccl-core ccl-core merged commit 2f77166 into main Sep 7, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants