AMD integration #132
Open
AMD integration #132
+64
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaywonchung
reviewed
Oct 17, 2024
This was
linked to
issues
Oct 17, 2024
jaywonchung
reviewed
Oct 21, 2024
zeus/device/gpu/amd.py
Outdated
Comment on lines
257
to
259
| """Check if the GPU supports retrieving total energy consumption. Returns a future object of the result.""" | ||
| wait_time = 0.5 # seconds | ||
| threshold = 0.8 # 80% threshold |
There was a problem hiding this comment.
Do we want to first check whether self._supportsGetTotalEnergyConsumption is not None and return the cached value for future invocations of this method?
There was a problem hiding this comment.
with the current structure it's never called more than once. But that would be better, I'll add it
There was a problem hiding this comment.
This method is part of the public API of GPU and GPUs, meaning people can always call it in their code. Thanks!
jaywonchung
reviewed
Oct 21, 2024
jaywonchung
reviewed
Oct 21, 2024
Co-authored-by: Jae-Won Chung <[email protected]>
|
@parthraut Is this ready for review? Did stuff work properly on the AMD HPC cluster? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few questions:
zeus/zeus/device/gpu/amd.py:247:13 - error: Operator "*" not supported for types "c_uint32" and "Literal[1000]" (reportOperatorIssue) zeus/zeus/device/gpu/amd.py:258:9 - error: Method "supportsGetTotalEnergyConsumption" overrides class "GPU" in an incompatible manner Positional parameter count mismatch; base method has 1, but override has 2 (reportIncompatibleMethodOverride) zeus/zeus/device/gpu/amd.py:280:26 - error: Cannot assign to attribute "_supportsGetTotalEnergyConsumption" for class "AMDGPU*" Attribute "_supportsGetTotalEnergyConsumption" is unknown (reportAttributeAccessIssue) zeus/zeus/device/gpu/amd.py:282:26 - error: Cannot assign to attribute "_supportsGetTotalEnergyConsumption" for class "AMDGPU*" Attribute "_supportsGetTotalEnergyConsumption" is unknown (reportAttributeAccessIssue) zeus/zeus/device/gpu/amd.py:293:26 - error: Cannot assign to attribute "_supportsGetTotalEnergyConsumption" for class "AMDGPU*" Attribute "_supportsGetTotalEnergyConsumption" is unknown (reportAttributeAccessIssue) zeus/zeus/device/gpu/amd.py:344:19 - error: Cannot access attribute "value" for class "AmdSmiException" Attribute "value" is unknown (reportAttributeAccessIssue) zeus/zeus/device/gpu/amd.py:346:37 - error: Cannot access attribute "msg" for class "AmdSmiException"I can fix these, but do you think this is the right approach? I wanted to make sure before tweaking base class signatures.