Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Add "deadline" and "finisheddate" attributes for the card. #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add "deadline" and "finisheddate" attributes for the card. #46

wants to merge 5 commits into from

Conversation

gxglhyy
Copy link

@gxglhyy gxglhyy commented Jun 28, 2020

Add "deadline" and "finisheddate" attributes for the card. And show "Assinged To", "deadline" , "finisheddate" on board's cards.

mkloubert
mkloubert reviewed Jul 1, 2020
View reviewed changes
Copy link
Owner

@mkloubert mkloubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Can you also change all finisheddate css class name suffixes to finished-date, like creation-time? Thanks! :)

src/boards.ts Outdated
/**
* The (optional) date, the cards has been finished.
*/
finisheddate?: string;
Copy link
Owner

@mkloubert mkloubert Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/workspaces.ts Outdated
if ('' !== deadline) {
META['Deadline'] = deadline;
}
let finisheddate = vscode_helpers.toStringSafe(C.finisheddate).trim();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
@@ -1855,6 +1927,8 @@ jQuery(() => {
const NEW_CARD = {
assignedTo: vsckb_get_assigned_to_val( ASSIGNED_TO_FIELD ),
category: category,
deadline: deadline,
finisheddate: finisheddate,
Copy link
Owner

@mkloubert mkloubert Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
i.assignedTo = vsckb_get_assigned_to_val(ASSIGNED_TO_FIELD);
i.title = TITLE;
i.description = vsckb_get_card_description_markdown( descriptionField );
i.details = vsckb_get_card_description_markdown( detailsField );
i.prio = PRIO;
i.type = type;
i.category = category;
i.deadline = deadline;
i.finisheddate = finisheddate;
Copy link
Owner

@mkloubert mkloubert Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
}

let finisheddate;
if (card.finisheddate) {
Copy link
Owner

@mkloubert mkloubert Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
@@ -899,6 +927,8 @@ function vsckb_refresh_card_view(onAdded) {
assigned_to: assignedTo,
cat: card.category,
category: card.category,
deadline: card.deadline,
finisheddate: card.finisheddate,
Copy link
Owner

@mkloubert mkloubert Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
NEW_ITEM_DEADLINE.show();
}

let finisheddate = "Finished Date: " + vsckb_to_string(i.finisheddate).trim();
Copy link
Owner

@mkloubert mkloubert Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated

let finisheddate;
if (card.finisheddate) {
finisheddate = card.finisheddate;
Copy link
Owner

@mkloubert mkloubert Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

src/res/js/board.js Outdated
DEADLINE_FIELD.val( vsckb_to_string(i.deadline).trim() );

const FINISHED_FIELD = WIN.find('#vsckb-edit-card-finisheddate');
FINISHED_FIELD.val( vsckb_to_string(i.finisheddate).trim() );
Copy link
Owner

@mkloubert mkloubert Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished_date

@mkloubert
Copy link
Owner

After that, you should update the versions in all package files to 1.29.0, update the CHANGELOG file and add you, if you want, as contributor to the README.

mkloubert
mkloubert reviewed Jul 1, 2020
View reviewed changes
src/res/js/board.js Outdated
deadline = undefined;
}

let finisheddate = vsckb_to_string( FINISHEDDATE_FIELD.val() ).trim();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be FINISHED_FIELD

mkloubert
mkloubert reviewed Jul 1, 2020
View reviewed changes
src/workspaces.ts Outdated
}
let finisheddate = vscode_helpers.toStringSafe(C.finisheddate).trim();
if ('' !== finisheddate) {
META['Finisheddate'] = finisheddate;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Finished date"

@mkloubert
Copy link
Owner

Ok my review finished ... sorry I hope I did not spam your mailbox with my updates!

Thanks a lot for your work! 👍

@gxglhyy
Copy link
Author

gxglhyy commented Jul 20, 2020

Hi, mkloubert,
I have fininshed the modification.

@gxglhyy gxglhyy requested a review from mkloubert August 3, 2020 07:28
@gxglhyy
Copy link
Author

gxglhyy commented Aug 5, 2020

Sorry, I find the bug about "NEW_ITEM_ASSIGNEDTO".
PS, I can't open the kanban's workspace in Extension Development Host window afer press F5, so I can't test enough.

@mkloubert mkloubert mentioned this pull request Oct 9, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkloubert mkloubert Awaiting requested review from mkloubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gxglhyy @mkloubert