set statement attributes #1315
Open
set statement attributes #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does seem like a missing piece of the API - thanks. Could you add at least one test for PostgreSQL, MySQL, or SQL Server? I'm also curious about the impetus for this. Were you looking for a statement timeout? |
|
I really like this idea. I really appreciate the note in the doc string that only integers are supported right now. That will help a lot. |
|
This could be useful for setting SQL_ATTR_ENABLE_AUTO_IPD statement attribute as well. |
keitherskine
reviewed
Mar 1, 2024
Comment on lines
+1115
to
+1116
| MAKECONST(SQL_IS_UINTEGER), | ||
| MAKECONST(SQL_IS_UINTEGER), |
There was a problem hiding this comment.
Duplicate lines. Should one of these be SQL_IS_INTEGER perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can set connection-level attributes via
set_attrbut not cursor-level settings. Note that I haven't had time for tests here yet, but can put them together if adding this to the project makes sense.