Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbolic link options #482

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Nov 1, 2022

  • Add enable_symlink boolean option for read, extractall, and extract
  • Add dereference boolean option for write and writeall
    • SevenZipFile constructor option dereference is marked deprecated and will be removed in future version

Signed-off-by: Hiroshi Miura [email protected]

py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
- Add enable_symlink boolean option for read, extractall, and extract
  - Default to be True. It will be False in future.
- Add dereference boolean option for write and writeall
  - SevenZipFile constructor option dereference is marked deprecated
     and will be removed in future version

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/security/symlink-extraction-optional branch from 97b90c6 to b5edae5 Compare February 12, 2023 06:15
@miurahr miurahr marked this pull request as ready for review October 11, 2024 00:44
Copy link
Owner Author

@miurahr miurahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should treat an argument dereferece of SevenZipFile constructor as a default of write and writeall methods, and users can override it in each write call.

py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/py7zr.py Outdated Show resolved Hide resolved
Use SevenZipFile argument dereference as default for extract methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant