-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore CI pipeline test for list-* commands #828
base: master
Are you sure you want to change the base?
restore CI pipeline test for list-* commands #828
Conversation
There's one failing run here (https://github.com/miurahr/aqtinstall/pull/828/checks?check_run_id=31143733858) that reproduces #817. |
Anything we can do about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to avoid an asterisk. Is there any other better name?
Avoid the use of `*` in subcommand names Co-authored-by: Hiroshi Miura <[email protected]>
Agreed; |
Signed-off-by: Hiroshi Miura <[email protected]>
In metadata.py: 779
|
Good, it should be failing there because no one has fixed #817 yet. |
I barely used python but I can try to fix by logic |
No, @Edgars-Cirulis, it's a lot more complicated than just this function. List-qt needs to look in two separate places for versions of qt for android now; this will be a major architectural change if we want it to report accurate results. You can try it if you want, but it will be a bigger job than you think. |
Could you describe the "two separate places" you're referring to? Thanks! I initially thought the issue was about handling folder names with multiple underscores in folder_to_version_extension, but your message made me.. theres something else. |
@Edgars-Cirulis could you read the discussion thread here ? For Android, there are several URLs for versions. |
Restore CI pipeline test for list-* commands.
See bdf8b4b#r147631586
I'm slightly concerned about using strings like
list-*
in Bash because of potential issues with wildcard character expansion. As long as these strings are quoted, I think they should be fine though.