Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*WIP* feat(health-check): health checks added for each container #121

Closed
wants to merge 3 commits into from

Conversation

bilalcaliskan
Copy link

@bilalcaliskan bilalcaliskan commented Feb 2, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds liveness/readiness probes for each possible container in a pod. It will make us ensure that our deployments are healthy all the time. This issue also reopened as a new PR because PR #117 is staled.

Which issue(s) this PR fixes:
Fixes #57

Special notes for your reviewer:
I had to add tcpSocket health probes for signaller port(8090) because application normally opens a single port, without varnish-exporter:

root@kube-httpcache-0:/# netstat -lntpu
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp6       0      0 :::8090                 :::*                    LISTEN      1/kube-httpcache

Also i have no idea how to publish new Helm chart https://helm.mittwald.de Helm repository. I could not examine deeply but i hope current Github actions handle that already.

@mittwald-machine
Copy link
Collaborator

There has not been any activity to this pull request in the last 14 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Helm chart with default liveness & readiness probes
2 participants