THREDDED_TESTAPP_SPROCKETS_JS was only used for Rails 6.0

mission-met · Jul 19, 2024 · 6a5401a · 6a5401a
1 parent 59f4690
commit 6a5401a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -113,9 +113,7 @@ jobs:
 
     - name: Install Node Packages via Yarn
       run: |
-        if [[ -z $THREDDED_TESTAPP_SPROCKETS_JS ]]; then
-          cd spec/dummy && yarn && cd -
-        fi
+        cd spec/dummy && yarn && cd -
 
     - name: "Run Tests: test:nojs"
       run: |

diff --git a/spec/dummy/config/application.rb b/spec/dummy/config/application.rb
@@ -27,7 +27,7 @@
 
 require 'web-console' if Rails.env.development?
 
-require 'webpacker' if Rails::VERSION::MAJOR >= 6 && ENV['THREDDED_TESTAPP_SPROCKETS_JS'] != '1'
+require 'webpacker' if Rails::VERSION::MAJOR >= 6
 
 module Dummy
   class Application < Rails::Application
@@ -80,7 +80,7 @@ class Application < Rails::Application
     config.load_defaults("#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}") if config.respond_to?(:load_defaults)
 
     def self.thredded_testapp_webpack?
-      Rails::VERSION::MAJOR >= 6 && ENV['THREDDED_TESTAPP_SPROCKETS_JS'] != '1'
+      Rails::VERSION::MAJOR >= 6
     end
   end
 end