Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new video player #216

Merged
merged 21 commits into from
Feb 18, 2024
Merged

feat: new video player #216

merged 21 commits into from
Feb 18, 2024

Conversation

MiaoMint
Copy link
Member

image

@bachig26
Copy link
Contributor

@MiaoMint as you can see in the screenshot, the settings button is covered when the app isn't in a fullscreen or at a certain window size and we can't access the button (for now say, this settings button), and the user need to re-size the window to use it.

this issue was also present in the public version (1.8.1 or earlier) of miru when you use the "Play List" button, please make it not have a conflict with the buttons due the vertical tabs/lists.

miru_NjmHyCRkFt

@bachig26
Copy link
Contributor

bachig26 commented Jan 27, 2024

@MiaoMint
few other suggestions:

  1. also, it sounds better having streamlink instead of play link?

miru_YS1tPmOzvE

  1. better seekbar, the previous was nice since it shows the cached/buffered length of the video. and also as you can see the duration isn't good, example instead of 1:09 (minutes) it shows as 1:9 and it's completely in minutes now instead of as hours (whihc i don't mind). but it's not perfect.

miru_PcYWevXVy6

  1. also the volume option doesn't support the mouse middle button scroll over to change the volume. previously it was possible.

@MiaoMint
Copy link
Member Author

MiaoMint commented Jan 28, 2024

image
image

@bachig26
Copy link
Contributor

@MiaoMint can you also add the "Rewind", "Fast-Forward" button for skipping along the play button?
if possible similar to this?

vivaldi_oMDW80XiLS
vivaldi_QDM807bO8k
vivaldi_vbdfZkGNAq

@DarkLite25
Copy link

DarkLite25 commented Jan 28, 2024

Thanks you it becomes perfect, now we will need multiple sources for the video, but what about android app? Can I test it.

@bachig26
Copy link
Contributor

the new video player has some bug with the play button as you can see in the clip, it shows as 'play' instead of 'pause' icon. i had to press twice to make the video pause as shown.

gO7XhzsJRo.mp4

@MiaoMint MiaoMint linked an issue Jan 29, 2024 that may be closed by this pull request
2 tasks
@bachig26
Copy link
Contributor

bachig26 commented Feb 2, 2024

a must needed improvement/feature to the video player:

  • Jump to next season: with this new and old player, we can jump to the next season while in the player, as the user need to change it in detail page and access episode. as you know at present, the user can only access the episodes on the current season they're on inside the player play list.

@MiaoMint please have a look at this and possibility in having it for the new video player.
it's wasn't comfortable with the old player and also not with the new player, while binge watching it's always an hassle and annoying to go back to the detail page.

@bachig26
Copy link
Contributor

bachig26 commented Feb 2, 2024

also i'm still seeing the play pause button mismatch issue as i have mentioned in a above comment happened again while i'm was accessing the audio track option.

@bachig26
Copy link
Contributor

bachig26 commented Feb 5, 2024

@MiaoMint is it possible make an custom option to define the position of the buttons (settings, volume, play list, etc) in video player. so, the user can move it like top right, bottom left, etc.?

@MiaoMint
Copy link
Member Author

MiaoMint commented Feb 5, 2024

@MiaoMint is it possible make an custom option to define the position of the buttons (settings, volume, play list, etc) in video player. so, the user can move it like top right, bottom left, etc.?

No plans yet

@bachig26
Copy link
Contributor

bachig26 commented Feb 5, 2024

thanks for the remember subtitle function, it's nice.

and also just noticed that there's no mute function, i tried to click the volume button (outside and within the volume slider) but it seems not available. can you able add it?

@MiaoMint MiaoMint marked this pull request as ready for review February 7, 2024 16:38
@MiaoMint MiaoMint merged commit 300346b into dev Feb 18, 2024
2 checks passed
@MiaoMint MiaoMint deleted the feat/new-video-player branch February 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants