Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make port reusable between sessions #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jupagose
Copy link

@jupagose jupagose commented Oct 26, 2022

Now if last port used is still available, is used this can avoid users the need of transmit "connection info" if need to connet again.

Try to reuse last port
Removed WPF version
This reverts commit 511bc39.
Reuse PORT
Remove unused code
@miroslavpejic85
Copy link
Owner

Hello @jupagose,

Thank you so much for this PR, but in this way:

  1. You can't open multiple simultaneous sessions of P2P Remote Desktop on the same PC.
  2. Are you sure that the port you forced and saved in the registry, still always open?
  3. The idea is also to make it cross-platform, so writing to the registry is also strictly for Windows OS.

What do you think?

Anyway thank you again and have a good day.

@jupagose
Copy link
Author

jupagose commented Dec 5, 2022

Hi, tks to take care about this and tks for this great project.

  1. If you are an intesive user, think on 40.. 50 connections by day, it means you must have 1500 port opened by month 18000 by year. To open simultaneous sessions we can save not one but a list of used ports, usually a support user have between 1 and 4 simultaneous sessions.
  2. Each port saved must be tested if the port cannot be used we must increment it until one is available as currently done, and must be replaced on config. On the same device it is strange that ports are reserved unless new applications are installed.
  3. You are ok, (sorry I'm a windows user ) This can be achieved using the .json config file to store the list of used ports.
  4. If you check teamviewer/Anydesk at firewall, there is only a few ports opened by them.

Let me know what you think about it.

Thank you again for the time invested in this great project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants