improving testFocus and testBlur #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-andreyev
force-pushed
the
improving-on-focus-test
branch
from
c852278
to
6ceaeea
Compare
- added test on anchor element
oleg-andreyev
force-pushed
the
improving-on-focus-test
branch
from
6ceaeea
to
faf2152
Compare
stof
reviewed
Jun 9, 2023
| @@ -56,6 +56,15 @@ public function testFocus() | |||
|
|
|||
| $focusBlurDetector->focus(); | |||
| $this->assertEquals('focused', $focusBlurDetector->getValue()); | |||
|
|
|||
| $focusableAnchor = $this->getAssertSession()->elementExists('css', '.elements a#focusable'); | |||
| $this->assertEquals('no action detected', $focusableAnchor->getText()); | |||
There was a problem hiding this comment.
This should be added as a separate tests. We want granular tests in that testsuite to make it easier to skip them when needed for unsupported things in each driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minkphp/MinkSelenium2Driver#304 (comment)