-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing window switching on Selenium 3 #384
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
============================================
+ Coverage 90.19% 90.52% +0.33%
- Complexity 168 180 +12
============================================
Files 1 1
Lines 469 517 +48
============================================
+ Hits 423 468 +45
- Misses 46 49 +3 ☔ View full report in Codecov by Sentry. |
ca5c4e0
to
67bb34e
Compare
67bb34e
to
716ac2a
Compare
ec98133
to
0ed565f
Compare
@stof , please review. Ideally please review my other PRs as well: https://github.com/minkphp/MinkSelenium2Driver/pulls/aik099 . |
9903ccc
to
2a85993
Compare
…now, instead of window handles
3749e26
to
c9a24f8
Compare
Fixes this error from the #383:
Implementation ported from the https://github.com/minkphp/webdriver-classic-driver.
What's included:
getWindowName
andgetWindowNames
methods to return window names instead of window handles (if the name is empty, then the handle is returned)Related issues:
Session::reset
call driver-testsuite#96