-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing NodeElement to/from JS scripts #352
Draft
mvorisek
wants to merge
4
commits into
minkphp:master
Choose a base branch
from
mvorisek:wdelem_from_selenium
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
Convert element to NodeElement from execute result
Allow passing NodeElement to/from scripts
Apr 15, 2022
stof
reviewed
Apr 15, 2022
mvorisek
force-pushed
the
wdelem_from_selenium
branch
from
April 17, 2022 23:18
0e5815c
to
47bba89
Compare
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
- Coverage 90.02% 87.25% -2.78%
- Complexity 150 161 +11
============================================
Files 1 1
Lines 421 455 +34
============================================
+ Hits 379 397 +18
- Misses 42 58 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mvorisek
force-pushed
the
wdelem_from_selenium
branch
from
April 20, 2022 10:44
47bba89
to
836909c
Compare
@stof I need to add a test, but can you please review this PR briefly? |
mvorisek
changed the title
Allow passing NodeElement to/from scripts
Allow passing NodeElement to/from JS scripts
Apr 20, 2022
mvorisek
force-pushed
the
wdelem_from_selenium
branch
2 times, most recently
from
April 20, 2022 12:57
61ff9ec
to
4d0d8f8
Compare
mvorisek
force-pushed
the
wdelem_from_selenium
branch
from
October 23, 2022 13:14
4d0d8f8
to
6c3cd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #353
no BC break (
\Behat\Mink\Driver\DriverInterface
interface cannot be updated inbehat/mink
v1.x, see related discussion minkphp/Mink#826, but this can be easily overcome by using@var
phpdoc in the code, see example below)serializing elements is natively supported by W3C WebDriver [1] and already fully supported by
instaclick/php-webdriver
[2] since v1.4.13[1] https://w3c.github.io/webdriver/#executing-script
[2] instaclick/php-webdriver#110
example usage:
outputs: