Merge pull request #359 from mvorisek/no_moveto_when_dragging_over_it…

…self Don't perform unneeded WebDriver\Session::moveto() call when dragging onto itself
minkphp · Nov 2, 2024 · db44be5 · db44be5
2 parents 28f43ec + 696ed94
commit db44be5
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/Selenium2Driver.php b/src/Selenium2Driver.php
@@ -978,12 +978,14 @@ public function dragTo(string $sourceXpath, string $destinationXpath)
     element.dispatchEvent(event);
 }({{ELEMENT}}));
 JS;
-        $this->withSyn()->executeJsOnElement($source, $script);
+        $this->executeJsOnElement($source, $script);
 
         $this->getWebDriverSession()->buttondown();
-        $this->getWebDriverSession()->moveto(array(
-            'element' => $destination->getID()
-        ));
+        if ($destination->getID() !== $source->getID()) {
+            $this->getWebDriverSession()->moveto(array(
+                'element' => $destination->getID()
+            ));
+        }
         $this->getWebDriverSession()->buttonup();
 
         $script = <<<JS
@@ -996,7 +998,7 @@ public function dragTo(string $sourceXpath, string $destinationXpath)
     element.dispatchEvent(event);
 }({{ELEMENT}}));
 JS;
-        $this->withSyn()->executeJsOnElement($destination, $script);
+        $this->executeJsOnElement($destination, $script);
     }
 
     public function executeScript(string $script)