Fix PHP RFC: Deprecate implicitly nullable parameter types

[andypost]

It will be a blocker for Drupal 11

Links

• https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
• https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

[aik099]

It will be a blocker for Drupal 11

@andypost , please explain how Mink method signatures are affecting/blocking Drupal?

[andypost]

Deprecation warnings affects tests so they fail.
In production you can disable this warnings

For example this pipeline

Testing Drupal\FunctionalJavascriptTests\Tests\JSWebAssertTest
    E                                                                   1 / 1
    (100%)
    Deprecated: Behat\Mink\Exception\ElementHtmlException::__construct():
    Implicitly marking parameter $exception as nullable is deprecated, the
    explicit nullable type must be used instead in
    /builds/issue/drupal-3427903/vendor/behat/mink/src/Exception/ElementHtmlException.php
    on line 39
    
    
    Time: 00:14.711, Memory: 8.00 MB
    
    There was 1 error:
    
    1) Drupal\FunctionalJavascriptTests\Tests\JSWebAssertTest::testJsWebAssert
    This test printed output: 
    Deprecated: Behat\Mink\Exception\ElementHtmlException::__construct():
    Implicitly marking parameter $exception as nullable is deprecated, the
    explicit nullable type must be used instead in
    /builds/issue/drupal-3427903/vendor/behat/mink/src/Exception/ElementHtmlException.php
    on line 39
    
    /builds/issue/drupal-3427903/vendor/phpunit/phpunit/src/Framework/TestResult.php:956
    
    ERRORS!
    Tests: 1, Assertions: 24, Errors: 1.

[aik099]

Good. Doesn't look like a BC break.

[andypost]

I did update of comment with example

[andypost]

I checked files with $ php -d error_reporting="E_ALL" -l Mink/*/*/* to make sure no more deprecations left

also https://3v4l.org/6T9GB/rfc

[andypost]

Last deprecations for PHP 8.4 will be commited in 2 weeks https://wiki.php.net/todo/php84

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (d8527fd) to head (4a730e1).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #869   +/-   ##
=========================================
  Coverage     98.72%   98.72%           
- Complexity      374      389   +15     
=========================================
  Files            24       24           
  Lines          1022     1022           
=========================================
  Hits           1009     1009           
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andypost]

Any chance to get this one commited? RC1 does not bring new deprecations

[aik099]

Merged, thank you @andypost .

[andypost]

@aik099 please create a new release with declared PHP 8.4 support, Drupal depends on it

[aik099]

@andypost , isn't a similar change needed for drivers?

[andypost]

better to check as Drupal showed no issues but it using limited set

[aik099]

better to check as Drupal showed no issues but it using limited set

I've tried searching for = null in method arguments and the only thing that showed up was a Zombie driver.

---

Created Mink 1.12.0 release. Please check if it helped.

[aik099]

@andypost , I see, that you're signing your git commits. Do you type a GPG key passphrase on every commit?

I'm using git on 2 OSes:

• on macOS via Sublime Merge app;
• on Linux (AlmaLinux) via git client.

Is there any way to have an OS-integrated SSH-agent analog that stores the GPG passphrase safely?

P.S.
Sublime Merge even doesn't ask for a passphrase.

[andypost]

Drupal using mink-selenium2-driver, mink-browserkit-driver and php-webdriver and no issues detected

[andypost]

@aik099 fyi all tests are passed for latest Drupal branches, thank you a lot!!!

[andypost]

@aik099 no I do not type, in my case Ubuntu and Github cares about keyring and mapping

[aik099]

Drupal using mink-selenium2-driver, mink-browserkit-driver and php-webdriver and no issues detected

@andypost ,

1. What version of Selenium Server are you using?
2. Do you have tests, that open and switch to new windows OR use frames?

[andypost]

@aik099 I've no idea about selenium as Drupal using Nightwatch + lullabot/mink-selenium2-driver and the selenium/standalone-chrome docker image for CI

And I can't find any tests opening windows, the only iframe usage I know is file-upload fallback but I see no tests covering it

[aik099]

The Docker image is likely using Selenium Server 3.x or 4.x.

The usage of a custom Selenium2 driver explains why everything is still working.

Thank you.