Feature/allow phpunit 10 #841
Conversation
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
============================================
- Coverage 98.47% 98.33% -0.14%
+ Complexity 345 344 -1
============================================
Files 23 23
Lines 983 903 -80
============================================
- Hits 968 888 -80
Misses 15 15 see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" /> |
There was a problem hiding this comment.
This makes us loose the existing feature where our CI fails if we trigger deprecated APIs, which is something we wanted to have
There was a problem hiding this comment.
Yes of course. This --migrate-configuration does remove it, and i did not checked the backup file. I will re-add this
There was a problem hiding this comment.
Actually, the symfony/phpunit-bridge is not yet compatible with PHPUnit 10. So this is a blocker for using it in our CI
There was a problem hiding this comment.
I just noticed that ;(
I added it, but outcommented the code. Xml-Names changed too, i am not sure if phunit 8 can handle the new Xml-Names.
There was a problem hiding this comment.
I guess the best solution is, to wait until the bridge symfony/phpunit-bridge is compatible with PHPUnit 10.
There could be 2 seperate phpunit (for 8/9 and 10) config files and a switch in the ci tests.
But i guess that is not what we want.
There was a problem hiding this comment.
Indeed. There is nothing wrong with using PHPUnit 9 in our CI. We don't want to maintain 2 configurations if we can avoid it.
However, the TestCase renaming and the migration to static methods for data-providers are something we could merge even if we don't use PHPUnit 10 yet.
There was a problem hiding this comment.
Ok, i will provide a seperate PR. (probably this weekend)
phpunit.xml.dist
Outdated
| <testsuite name="Behat Mink test suite"> | ||
| <directory>tests</directory> | ||
| <exclude>./tests/Element/ElementTest.php</exclude> | ||
| <exclude>./tests/Selector/NamedSelectorTest.php</exclude> |
There was a problem hiding this comment.
excluding some tests is a no-go. Our testsuite must run.
If those are not actually tests but abstract test cases, the right fix is to rename them rather than having to maintain exclude rules.
There was a problem hiding this comment.
These are abstract Tests. I changed the tests. There are of course multiple solutions. Please check if my solution is ok.
|
This PR also includes the changes from #842 . Not sure if that was planned. |
|
@aik099 Yes this in intended, please see #841 (comment) |
The 2 abstract Test-Classes are excludet to nor raise Warnings and break CI-runs.