Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the profiler easier to use #5068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the profiler easier to use #5068

wants to merge 1 commit into from
+6 −0

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Oct 23, 2024 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Make the profiler easier to use.

Motivation and Context

How to test this PR?

before:
export MC_PROFILER=goroutine
mc alias list
image
after fix:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze
Update profiling.go
41bb413 
Make the profiler easier to use
klauspost
klauspost approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know we had that feature. Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dormanze @klauspost @shtripat