Add string/json output string mc pipe #5065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a string message and json output to mc pipe. The implementation is heavily inspired by the one in mc cp, just adapted to the different semantics of pipe.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
The
mc pipe
command doesn't currently do anything with the--json
global flag, and this PR implements that. Feel free to suggest any changes to make this more conformant with project style or other requirements.Motivation and Context
Comparing the number of bytes copied with the number of bytes expected is do a simple end-to-end check that an upload went as expected.
How to test this PR?
Pass
--json
tomc pipe
and observe the output:It also adds a plain text message due to the requirements of printMsg:
Types of changes
Checklist:
commit-id
orPR #
here)