Report errors and better file names for mc support inspect #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty basic information right now:
Example:
```
λ mc support top rpc myminio
SERVER CONCTD PING OUT Q RECONNS STR IN STR OUT MSG IN MSG OUT
To 127.0.0.1:9001 5 0.5ms 0 0 -> 20 0 -> 60007 60089
From 127.0.0.1:9001 5 0.5ms 0 0 -> 0 20 -> 60089 60002
To 127.0.0.1:9002 5 0.0ms 0 0 -> 0 4 -> 34209 33937
From 127.0.0.1:9002 5 0.5ms 0 0 -> 4 0 -> 33938 34209
To 127.0.0.1:9003 5 0.0ms 0 0 -> 0 4 -> 99379 101165
From 127.0.0.1:9003 5 0.0ms 0 0 -> 4 0 -> 101166 99379
To 127.0.0.1:9004 5 0.5ms 0 0 -> 0 4 -> 33784 33029
From 127.0.0.1:9004 5 0.0ms 0 0 -> 4 0 -> 33030 33784
To 127.0.0.1:9005 5 0.0ms 0 0 -> 0 4 -> 33515 33135
From 127.0.0.1:9005 5 0.5ms 0 0 -> 4 0 -> 33136 33515
To 127.0.0.1:9006 5 0.0ms 0 0 -> 0 4 -> 33627 33161
From 127.0.0.1:9006 5 0.0ms 0 0 -> 4 0 -> 33162 33627
```
There is already server support for metrics.
# Conflicts: # cmd/support-top-rcp.go # cmd/support-top.go
Check the returned stream for errors and show them. Don't upload/keep pointless data Use the request alias to create a better file name... Example: ``` λ mc support inspect play/testbucket/testdat/** mc: <ERROR> Unable to download file data. GetRawData: No files matched the given pattern. ``` Previously the error would just be ignored. ``` λ mc support inspect --airgap play/testbucket/testdata/** File data successfully downloaded as inspect-play_testbucket_testdata.enc ``` Previously all files would be called `inspect-data.enc`, which would just be difficult to distinguish.
klauspost
force-pushed
the
inspect-errors
branch
from
cf513cf
to
9e0df6d
Compare
zveinn
approved these changes
Oct 15, 2024
harshavardhana
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check the returned stream for errors and show them. Don't upload/keep pointless data
Use the request alias to create a better file name...
Example:
Previously the error would just be ignored.
Previously all files would be called
inspect-data.enc, which would just be difficult to distinguish.How to test this PR?
See above
Types of changes