Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import bucket metadata must show CORS and general errors if any are found #5001

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

marktheunissen
Copy link
Contributor

@marktheunissen marktheunissen commented Jul 29, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

  • Fix a bug where any error on the zip file itself (rather than a specific bucket) was not reported, e.g. malformed directory.
  • Report whether CORS bucket settings were imported successfully

Motivation and Context

How to test this PR?

Example of failed import errors, with this PR:

0/2 buckets were imported successfully.
Errors:

Name      : BADFORMAT/corsexporttest/cors.xml
  Error:  malformed zip - expecting format bucket/<config.json>

Name      : corsexporttest
  Notification:  ✔
  Quota:  ✔
  CORS:  ✗

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

go.mod Outdated Show resolved Hide resolved
@marktheunissen marktheunissen marked this pull request as ready for review July 31, 2024 06:11
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

go.sum Outdated Show resolved Hide resolved
@marktheunissen marktheunissen force-pushed the bucketcors branch 3 times, most recently from 32a531c to 265b270 Compare August 6, 2024 00:39
@marktheunissen marktheunissen force-pushed the bucketcors branch 2 times, most recently from 6f4383b to 2bf5700 Compare August 6, 2024 03:22
@marktheunissen marktheunissen dismissed harshavardhana’s stale review August 12, 2024 05:01

please recheck, I have removed personal imports and pulled in correct ones

@marktheunissen
Copy link
Contributor Author

@harshavardhana please re-review and merge if happy, thanks.

Copy link
Contributor

@zveinn zveinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 21ab58a into minio:master Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants