Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin-info: Include delete markers count #4642

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

krisis
Copy link
Member

@krisis krisis commented Jul 19, 2023

Description

Add total number of delete markers to the usage summary section of admin-info output.

Motivation and Context

To allow users to track unusual application behavior like creating excessive delete markers, usually since the application is not bucket versioning aware.

How to test this PR?

mc admin info ALIAS

Sample output

mc admin info play
●  play.min.io
   Uptime: 5 hours
   Version: 2023-07-19T05:25:12Z
   Network: 1/1 OK
   Drives: 4/4 OK
   Pool: 1

Pools:
   1st, Erasure sets: 1, Drives per erasure set: 4

11 GiB Used, 428 Buckets, 38,035 Objects, 54,636 Versions, 26,363 Delete Markers
4 drives online, 0 drives offline

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member

How about we reformat it like this

mc admin info play
●  play.min.io
   Uptime: 5 hours
   Version: 2023-07-19T05:25:12Z
   Network: 1/1 OK
   Drives: 4/4 OK
   Pool: 1

Pools:
   1st, Erasure sets: 1, Drives per erasure set: 4

Used   |  Buckets  |  Objects | Versions | Delete Markers |
11 GiB |  428      |  38,035  | 54,636   | 26,363         |

4 drives online, 0 drives offline

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 0574701 into minio:master Jul 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants