Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix replicate update to check for older role ARN #4640

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix replicate update to check for older role ARN #4640

merged 1 commit into from
Jul 19, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jul 19, 2023 •
edited
Loading

Description

Motivation and Context

Backward compatibility for older replication config that has ARN in the Role field

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

vadmeste
vadmeste approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit c04a480 into minio:master Jul 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@krisis krisis Awaiting requested review from krisis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poornas @vadmeste @harshavardhana