Enabled option to show node and bucket metrics #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Jul 19, 2023
shtripat
force-pushed
the
node-and-bucket-metrics
branch
from
23c91f4
to
1e0aecf
Compare
vadmeste
reviewed
Jul 19, 2023
vadmeste
requested changes
Jul 19, 2023
shtripat
force-pushed
the
node-and-bucket-metrics
branch
from
1e0aecf
to
c08477d
Compare
harshavardhana
approved these changes
Jul 19, 2023
harshavardhana
requested changes
Jul 19, 2023
Earlier the command `mc admin prometheus metrics ALIAS` used to display only the cluster levele metrics. This change enables optionally to list node / bucket specific metrics. Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
node-and-bucket-metrics
branch
from
c08477d
to
6027177
Compare
harshavardhana
approved these changes
Jul 20, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier the command
mc admin prometheus metrics ALIASused to display only the cluster level metrics. This change enables optionally to list node / bucket specific metrics.Motivation and Context
Enable listing of node and bucket specific metrics
How to test this PR?
mc admin prometheus metrics ALIAS nodemc admin prometheus metrics ALIAS bucketTypes of changes
Checklist:
commit-idorPR #here)