Fixing misleading usage help for mc anonymous set-json #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed USAGE according to the program behavior: set-json needs TARGET first and then FILE
Fixed other misleading helps of usage set-json option
|
Please fix the PR title |
Sorry. Fixed. |
|
Hi again! |
harshavardhana
approved these changes
Jul 18, 2023
klauspost
approved these changes
Jul 18, 2023
bjw-s
referenced
this pull request
in bjw-s/dotfiles
Jul 19, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [mc](https://togithub.com/minio/mc) | patch | `2023-07-11T23-30-44Z` -> `2023-07-18T21-05-38Z` | --- ### Release Notes <details> <summary>minio/mc (mc)</summary> ### [`v2023-07-18T21-05-38Z`](https://togithub.com/minio/mc/releases/tag/RELEASE.2023-07-18T21-05-38Z): Bug Fix Release [Compare Source](https://togithub.com/minio/mc/compare/RELEASE.2023-07-11T23-30-44Z...RELEASE.2023-07-18T21-05-38Z) ##### What's Changed - allow purge to happen on quorum lost objects by [@​harshavardhana](https://togithub.com/harshavardhana) in [https://github.com/minio/mc/pull/4629](https://togithub.com/minio/mc/pull/4629) - Rename mc replicate diff as mc replicate backlog by [@​poornas](https://togithub.com/poornas) in [https://github.com/minio/mc/pull/4568](https://togithub.com/minio/mc/pull/4568) - Added `endpoint` and `version` attributes to KMS details by [@​shtripat](https://togithub.com/shtripat) in [https://github.com/minio/mc/pull/4591](https://togithub.com/minio/mc/pull/4591) - Ensure `--airgap` is available on all support commands by [@​anjalshireesh](https://togithub.com/anjalshireesh) in [https://github.com/minio/mc/pull/4633](https://togithub.com/minio/mc/pull/4633) - run gofumpt -extra on all source files by [@​harshavardhana](https://togithub.com/harshavardhana) in [https://github.com/minio/mc/pull/4634](https://togithub.com/minio/mc/pull/4634) - Fixing misleading usage help for mc anonymous set-json by [@​mesif](https://togithub.com/mesif) in [https://github.com/minio/mc/pull/4621](https://togithub.com/minio/mc/pull/4621) - Support mc top net by [@​jiuker](https://togithub.com/jiuker) in [https://github.com/minio/mc/pull/4626](https://togithub.com/minio/mc/pull/4626) - fix: with --purge flag ignore path validation errors by [@​harshavardhana](https://togithub.com/harshavardhana) in [https://github.com/minio/mc/pull/4636](https://togithub.com/minio/mc/pull/4636) ##### New Contributors - [@​mesif](https://togithub.com/mesif) made their first contribution in [https://github.com/minio/mc/pull/4621](https://togithub.com/minio/mc/pull/4621) **Full Changelog**: minio/mc@RELEASE.2023-07-11T23-30-44Z...RELEASE.2023-07-18T21-05-38Z </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMC4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed misleading usage help for mc anonymous set-json.
Motivation and Context
Command:
mc anonymous set-jsonis working only with such a sequence:
mc anonymous set-json cluster/bucket/path /path/to/jsonSo the command help needs to be corrected.
How to test this PR?
Just run the binary with the proper options:
mc anonymous set-json cluster/bucket/path /path/to/json