Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map2 #174

Closed
wants to merge 7 commits into from
Closed

Map2 #174

wants to merge 7 commits into from

Conversation

awoods
Copy link
Contributor

@awoods awoods commented Aug 3, 2023

Supersedes: #149

This feature adds a new option/page in the navbar that displays all items in the collection that have a value in the latitude and longitude columns in the project CSV file. This works out-of-the-box.

This is a port from https://github.com/CollectionBuilder/collectionbuilder-csv.

Related user documentation pull-request: minicomp/wiki#34

For an existing demonstration: https://history.lakecountypubliclibrary.org/cmhc/map/

@awoods
Copy link
Contributor Author

awoods commented Aug 3, 2023

The HTML Proofer error will go away once this PR is merged. It is looking for a published page (https://minicomp.github.io/wax/map/) that is being created in this PR.

@mnyrop
Copy link
Member

mnyrop commented Aug 7, 2023

@awoods thanks for this! we'll need to stash the PR for awhile since we need to think more holistically about how to expand theme features for a v2 (i.e., what layouts/includes should be in a core theme? what components could live as "extensions" and how might that work? what could exist as a curated "recipe" for others to implement?) maps are probably the top feature for us to really think about in this regard. so with that said, i'll probably close the PR and reach out if/when we reopen or integrate it into a new version.

in the meantime, is there a preferred way for me to boost this work you've done as a model? is there a blog post/write up/documentation that exists? if not i can try to think of a way to highlight the repo & live site on our (WiP) examples list and tag it for mapping. it looks really great and should definitely get boosted to the community.

@mnyrop mnyrop closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants