Skip to content

Commit

Permalink
Avoid using nightly packages
Browse files Browse the repository at this point in the history
  • Loading branch information
breuleux authored and Delaunay committed Apr 17, 2023
1 parent 701c499 commit b3ae50f
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 47 deletions.
5 changes: 0 additions & 5 deletions benchmarks/dlrm/_requirements.in

This file was deleted.

8 changes: 2 additions & 6 deletions benchmarks/dlrm/benchfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,10 @@ class DLRMBenchmarkPack(Package):
main_script = "dlrm/dlrm_s_pytorch.py"

async def install(self):
code:XPath = self.dirs.code
dlrm:XPath = code / "dlrm"
code: XPath = self.dirs.code
dlrm: XPath = code / "dlrm"
if not dlrm.exists():
dlrm.clone_subtree("https://github.com/facebookresearch/dlrm", BRANCH)
reqs:XPath = code / "requirements.in"
reqs.write_text("\n".join(((dlrm / "requirements.txt").read_text(),
(code / "_requirements.in").read_text())))

await super().install()


Expand Down
34 changes: 17 additions & 17 deletions benchmarks/dlrm/requirements.cuda.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --output-file=benchmarks/dlrm/requirements.cu118.txt --resolver=backtracking .pin-constraints-dlrm.txt benchmarks/dlrm/requirements.in
# pip-compile --output-file=benchmarks/dlrm/requirements.cuda.txt --resolver=backtracking .pin-constraints-dlrm.txt benchmarks/dlrm/requirements.in
#
--extra-index-url https://download.pytorch.org/whl/cu118

Expand Down Expand Up @@ -41,29 +41,29 @@ codefind==0.1.3
docker==6.0.1
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
docstring-parser==0.8.1
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
executing==1.2.0
# via
# -c .pin-constraints-torch.txt
# varname
fbgemm-gpu-nightly==2023.4.4
fbgemm-gpu==0.4.1
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
filelock==3.10.7
# via
# -c .pin-constraints-torch.txt
# torch
# torchx-nightly
# torchx
# triton
fsspec==2023.3.0
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
future==0.18.3
# via -r benchmarks/dlrm/requirements.in
giving==0.4.2
Expand Down Expand Up @@ -92,15 +92,15 @@ idna==3.4
# via
# -c .pin-constraints-torch.txt
# requests
importlib-metadata==6.1.0
importlib-metadata==6.4.1
# via
# -c .pin-constraints-torch.txt
# markdown
# torchx-nightly
# torchx
iopath==0.1.10
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
# torchrec
jinja2==3.1.2
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -173,7 +173,7 @@ packaging==23.0
pandas==2.0.0
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
# torchrec
portalocker==2.7.0
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -213,7 +213,7 @@ pyparsing==3.0.9
pyre-extensions==0.0.30
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
python-dateutil==2.8.2
# via
# -c .pin-constraints-torch.txt
Expand All @@ -226,7 +226,7 @@ pyyaml==6.0
# via
# -c .pin-constraints-torch.txt
# omegaconf
# torchx-nightly
# torchx
reactivex==4.0.4
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -293,18 +293,18 @@ torch==2.0.0+cu118
torchmetrics==0.11.4
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
torchrec-nightly==2023.4.4
# torchrec
torchrec==0.4.0
# via -r benchmarks/dlrm/requirements.in
torchviz==0.0.2
# via -r benchmarks/dlrm/requirements.in
torchx-nightly==2023.4.4
torchx==0.5.0
# via -r benchmarks/dlrm/requirements.in
tqdm==4.65.0
# via
# -r benchmarks/dlrm/requirements.in
# iopath
# torchrec-nightly
# torchrec
triton==2.0.0
# via
# -c .pin-constraints-torch.txt
Expand All @@ -331,7 +331,7 @@ urllib3==1.26.15
# -c .pin-constraints-torch.txt
# docker
# requests
# torchx-nightly
# torchx
varname==0.10.0
# via
# -c .pin-constraints-torch.txt
Expand Down
6 changes: 2 additions & 4 deletions benchmarks/dlrm/requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ torch
torchviz
scikit-learn
tqdm
torchrec-nightly
torchx-nightly

# Final 'requirements.in' is generated during milabench install
torchrec
torchx
tensorboard

# Following limits are for milabench
Expand Down
30 changes: 15 additions & 15 deletions benchmarks/dlrm/requirements.rocm.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ codefind==0.1.3
docker==6.0.1
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
docstring-parser==0.8.1
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
executing==1.2.0
# via
# -c .pin-constraints-torch.txt
# varname
fbgemm-gpu-nightly==2023.4.4
fbgemm-gpu==0.4.1
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
Expand All @@ -63,7 +63,7 @@ filelock==3.10.7
fsspec==2023.3.0
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
future==0.18.3
# via -r benchmarks/dlrm/requirements.in
giving==0.4.2
Expand Down Expand Up @@ -92,15 +92,15 @@ idna==3.4
# via
# -c .pin-constraints-torch.txt
# requests
importlib-metadata==6.1.0
importlib-metadata==6.4.1
# via
# -c .pin-constraints-torch.txt
# markdown
# torchx-nightly
# torchx
iopath==0.1.10
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
# torchrec
jinja2==3.1.2
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -173,7 +173,7 @@ packaging==23.0
pandas==2.0.0
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
# torchrec
portalocker==2.7.0
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -213,7 +213,7 @@ pyparsing==3.0.9
pyre-extensions==0.0.30
# via
# -c .pin-constraints-torch.txt
# torchx-nightly
# torchx
python-dateutil==2.8.2
# via
# -c .pin-constraints-torch.txt
Expand All @@ -230,7 +230,7 @@ pyyaml==6.0
# via
# -c .pin-constraints-torch.txt
# omegaconf
# torchx-nightly
# torchx
reactivex==4.0.4
# via
# -c .pin-constraints-torch.txt
Expand Down Expand Up @@ -297,18 +297,18 @@ torch==2.0.0+rocm5.4.2
torchmetrics==0.11.4
# via
# -c .pin-constraints-torch.txt
# torchrec-nightly
torchrec-nightly==2023.4.4
# torchrec
torchrec==0.4.0
# via -r benchmarks/dlrm/requirements.in
torchviz==0.0.2
# via -r benchmarks/dlrm/requirements.in
torchx-nightly==2023.4.4
torchx==0.5.0
# via -r benchmarks/dlrm/requirements.in
tqdm==4.65.0
# via
# -r benchmarks/dlrm/requirements.in
# iopath
# torchrec-nightly
# torchrec
typing-extensions==4.5.0
# via
# -c .pin-constraints-torch.txt
Expand All @@ -331,7 +331,7 @@ urllib3==1.26.15
# -c .pin-constraints-torch.txt
# docker
# requests
# torchx-nightly
# torchx
varname==0.10.0
# via
# -c .pin-constraints-torch.txt
Expand Down

0 comments on commit b3ae50f

Please sign in to comment.